Skip to content

inspector: support inspecting HTTP/2 request and response bodies #60483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

inspector: support inspecting HTTP/2 request and response bodies #60483

merged 1 commit into from
Nov 4, 2025
+133 −10

Conversation

@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented Oct 29, 2025 •
edited
Loading

Now, we can track the request and response bodies of HTTP/2 calls through the Network tab of Chrome DevTools for Node.js.

Refs: #53946

Demo

demo.mov

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2025

Review requested:

  • @nodejs/http2
  • @nodejs/inspector
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 29, 2025
@RaisinTen RaisinTen mentioned this pull request Oct 29, 2025
Open
5 tasks
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.28916% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (f46152f) to head (f67af83).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_http2.js 72.28% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60483      +/-   ##
==========================================
- Coverage   88.58%   88.55%   -0.04%     
==========================================
  Files         704      704              
  Lines      207839   207922      +83     
  Branches    40051    40050       -1     
==========================================
+ Hits       184117   184124       +7     
- Misses      15791    15828      +37     
- Partials     7931     7970      +39
Files with missing lines Coverage Δ
lib/internal/inspector/network_http2.js 87.73% <72.28%> (-7.21%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas
legendecas reviewed Oct 29, 2025
View reviewed changes
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Oct 29, 2025
@RaisinTen RaisinTen mentioned this pull request Oct 31, 2025
Closed
ronag
ronag reviewed Oct 31, 2025
View reviewed changes
@RaisinTen RaisinTen mentioned this pull request Nov 1, 2025
Merged
legendecas
legendecas reviewed Nov 1, 2025
View reviewed changes
@RaisinTen
inspector: support inspecting HTTP/2 request and response bodies
f67af83 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen force-pushed the network-inspector-http2-request-response-data branch from 6430e7f to f67af83 Compare November 1, 2025 14:54
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69997/

islandryu
islandryu approved these changes Nov 2, 2025
View reviewed changes
Copy link
Member

@islandryu islandryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70007/

mcollina
mcollina approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70026/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70030/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70031/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit c63e88e into nodejs:main Nov 4, 2025
70 of 74 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

Landed in c63e88e

@RaisinTen RaisinTen deleted the network-inspector-http2-request-response-data branch November 4, 2025 08:44
aduh95 pushed a commit that referenced this pull request Nov 5, 2025
@RaisinTen @aduh95
inspector: support inspecting HTTP/2 request and response bodies
d2087ba 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #60483
Refs: #53946
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronag ronag ronag left review comments

@mcollina mcollina mcollina approved these changes

@legendecas legendecas legendecas approved these changes

@islandryu islandryu islandryu approved these changes

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen @nodejs-github-bot @mcollina @ronag @legendecas @islandryu